all repos — hex @ ba15abf867f492861fb6dce733580a46f91d0829

A tiny, minimalist, slightly-esoteric concatenative programming lannguage. 

Added comments to mark todo items for variable-length encoding.
h3rald h3rald@h3rald.com
Wed, 18 Dec 2024 11:50:51 +0100
commit

ba15abf867f492861fb6dce733580a46f91d0829

parent

644354adf535192be351f746e514f02e549b34ae

1 files changed, 5 insertions(+), 2 deletions(-)

jump to
M src/vm.c → src/vm.c 
@@ -432,7 +432,6 @@ }
     (*bytecode)[*size] = HEX_OP_PUSHIN;
     *size += 1; // opcode
     encode_length(bytecode, size, sizeof(int32_t));
-    // memcpy(&(*bytecode)[*size], &value, sizeof(int32_t));
     memcpy(&(*bytecode)[*size], (uint8_t[]){(value >> 24) & 0xFF, (value >> 16) & 0xFF, (value >> 8) & 0xFF, value & 0xFF}, 4);
     *size += sizeof(int32_t);
     return 0;

@@ -657,9 +656,10 @@ {
         hex_error(ctx, "Bytecode size too small to contain an integer");
         return 1;
     }
+    // TODO: Optimize: we are always using 4 bytes for the length, but we could use a variable length encoding
+    // size_t int_size = ((*bytecode)[0] << 24) | ((*bytecode)[1] << 16) | ((*bytecode)[2] << 8) | (*bytecode)[3];
     // Integers are always 4 bytes, big-endian, but at the moment we are always setting the size to 4
     // So just shifting the bytes to the right should be enough (no need to actually compute the size)
-    // size_t int_size = ((*bytecode)[0] << 24) | ((*bytecode)[1] << 16) | ((*bytecode)[2] << 8) | (*bytecode)[3];
     *bytecode += 4;
     *size -= 4;
     uint32_t value = ((*bytecode)[0] << 24) | ((*bytecode)[1] << 16) | ((*bytecode)[2] << 8) | (*bytecode)[3];

@@ -678,6 +678,7 @@ {
         hex_error(ctx, "Bytecode size too small to contain a string length");
         return 1;
     }
+    // TODO: Optimize: we are always using 4 bytes for the length, but we could use a variable length encoding
     size_t length = ((*bytecode)[0] << 24) | ((*bytecode)[1] << 16) | ((*bytecode)[2] << 8) | (*bytecode)[3];
     *bytecode += 4;
     *size -= 4;

@@ -747,6 +748,7 @@ {
         hex_error(ctx, "Bytecode size too small to contain a symbol length");
         return 1;
     }
+    // TODO: Optimize: we are always using 4 bytes for the length, but we could use a variable length encoding
     size_t length = ((*bytecode)[0] << 24) | ((*bytecode)[1] << 16) | ((*bytecode)[2] << 8) | (*bytecode)[3];
     *bytecode += 4;
     *size -= 4;

@@ -790,6 +792,7 @@ {
         hex_error(ctx, "Bytecode size too small to contain a quotation length");
         return 1;
     }
+    // TODO: Optimize: we are always using 4 bytes for the number of items, but we could use a variable length encoding
     size_t n_items = ((*bytecode)[0] << 24) | ((*bytecode)[1] << 16) | ((*bytecode)[2] << 8) | (*bytecode)[3];
     *bytecode += 4;
     *size -= 4;